Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, 26 May 2016, Chanwoo Choi wrote:

> On Thu, May 26, 2016 at 8:56 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> > On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote:
> >> I don't recommend that you mention the name of engineer on patch description
> >> directly.
> >
> > This really is normal.  I've been mentioned over 100 times in commit
> > messages like 7051924f771 (xillybus: Move out of staging).
>
> I'm still reluctant to use the name on description.
> How about you use the Suggested-by tag as following?
>
> [julia.lawall : Suggest that it is not necessary to check return value
> of platform_get_resource]
> Suggested-by: Julia Lawall <julia.lawall@xxxxxxx>

Like Dan, I really don't see the problem.  The text in [ ] looks ugly.  A
suggested by by itself would not be appropriate, since I didn't identify
the original issue.  There are ther patches that refer to peoples'
comments in a similar way.  Example:
d8aacd87180141ff6b812b53de77a4336e87c91a

julia
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux