Em Mon, 28 Dec 2015 15:38:54 +0100 SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> escreveu: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Mon, 28 Dec 2015 15:10:30 +0100 > > This issue was detected by using the Coccinelle software. > > Move the jump label directly before the desired log statement > so that the variable "ret" will not be checked once more > after a function call. > Use the identifier "report_failure" instead of "err". > > Suggested-by: Julia Lawall <julia.lawall@xxxxxxx> > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > drivers/media/tuners/m88rs6000t.c | 154 +++++++++++++++++++------------------- > 1 file changed, 78 insertions(+), 76 deletions(-) > > diff --git a/drivers/media/tuners/m88rs6000t.c b/drivers/media/tuners/m88rs6000t.c > index 504bfbc..7e59a9f 100644 > --- a/drivers/media/tuners/m88rs6000t.c > +++ b/drivers/media/tuners/m88rs6000t.c > @@ -44,7 +44,7 @@ static int m88rs6000t_set_demod_mclk(struct dvb_frontend *fe) > /* select demod main mclk */ > ret = regmap_read(dev->regmap, 0x15, &utmp); > if (ret) > - goto err; > + goto report_failure; Why to be so verbose? Calling it as "err" is enough, and it means less code to type if we need to add another goto. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
