Re: [PATCH 6/7] drivers: net: cpsw: fix error return code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/26/2015 8:40 PM, Julia Lawall wrote:

diff --git a/drivers/net/ethernet/ti/cpsw.c
b/drivers/net/ethernet/ti/cpsw.c
index 3409e80..6a76992 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pdev)

   	/* RX IRQ */
   	irq = platform_get_irq(pdev, 1);
-	if (irq < 0)
+	if (irq < 0) {
+		ret = -ENOENT;

    Why not just propagate an error returned by that function?

OK, I did what was done a few lines before in the same function:

         ndev->irq = platform_get_irq(pdev, 1);
         if (ndev->irq < 0) {
		dev_err(priv->dev, "error getting irq resource\n");
                 ret = -ENOENT;
                 goto clean_ale_ret;
         }

Maybe they should all be changed?

   Yeah, I'd vote for it. I'm seeing no sense in overriding an actual error.

[...]

julia

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux