> > diff --git a/drivers/net/ethernet/ti/cpsw.c
> > b/drivers/net/ethernet/ti/cpsw.c
> > index 3409e80..6a76992 100644
> > --- a/drivers/net/ethernet/ti/cpsw.c
> > +++ b/drivers/net/ethernet/ti/cpsw.c
> > @@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pdev)
> >
> > /* RX IRQ */
> > irq = platform_get_irq(pdev, 1);
> > - if (irq < 0)
> > + if (irq < 0) {
> > + ret = -ENOENT;
>
> Why not just propagate an error returned by that function?
OK, I did what was done a few lines before in the same function:
ndev->irq = platform_get_irq(pdev, 1);
if (ndev->irq < 0) {
dev_err(priv->dev, "error getting irq resource\n");
ret = -ENOENT;
goto clean_ale_ret;
}
Maybe they should all be changed?
julia
> > goto clean_ale_ret;
> > + }
> >
> > priv->irqs_table[0] = irq;
> > ret = devm_request_irq(&pdev->dev, irq, cpsw_rx_interrupt,
> > @@ -2461,8 +2463,10 @@ static int cpsw_probe(struct platform_device *pdev)
> >
> > /* TX IRQ */
> > irq = platform_get_irq(pdev, 2);
> > - if (irq < 0)
> > + if (irq < 0) {
> > + ret = -ENOENT;
>
> Likewise?
>
> [...]
>
> MBR, Sergei
>
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
