re: bnxt_en: New Broadcom ethernet driver.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Michael Chan,

The patch c0c050c58d84: "bnxt_en: New Broadcom ethernet driver." from
Oct 22, 2015, leads to the following static checker warning:

	drivers/net/ethernet/broadcom/bnxt/bnxt.c:5337 bnxt_rx_flow_steer()
	warn: impossible condition '(new_fltr->sw_id < 0) => (0-65535 < 0)'

drivers/net/ethernet/broadcom/bnxt/bnxt.c
  5335          new_fltr->sw_id = bitmap_find_free_region(bp->ntp_fltr_bmap,
  5336                                                    BNXT_NTP_FLTR_MAX_FLTR, 0);
  5337          if (new_fltr->sw_id < 0) {
                   ^^^^^^^^^^^^^^^^^^^^
Unsigned never less than zero.

  5338                  spin_unlock_bh(&bp->ntp_fltr_lock);
  5339                  rc = -ENOMEM;
  5340                  goto err_free;
  5341          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux