Hi Dan, Thank you for the patch. On Thursday 22 October 2015 12:09:05 Dan Carpenter wrote: > Smatch is not smart enough to see that "&stream->clock.lock" and > "&clock->lock" are the same thing so it complains about the locking > here. Let's make it more consistent. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> and applied to my tree. > diff --git a/drivers/media/usb/uvc/uvc_video.c > b/drivers/media/usb/uvc/uvc_video.c index 2b276ab..4abe3e9 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -709,7 +709,7 @@ void uvc_video_clock_update(struct uvc_streaming > *stream, vbuf->timestamp.tv_usec = ts.tv_nsec / NSEC_PER_USEC; > > done: > - spin_unlock_irqrestore(&stream->clock.lock, flags); > + spin_unlock_irqrestore(&clock->lock, flags); > } > > /* ------------------------------------------------------------------------ -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html