On 7/14/2015 1:51 PM, Bjorn Helgaas wrote: > On Tue, Jul 14, 2015 at 01:23:23PM -0700, Ray Jui wrote: >> Hi Bjorn, >> >> On 7/14/2015 1:10 PM, Bjorn Helgaas wrote: >>> On Sun, Jun 28, 2015 at 04:52:16PM +0200, SF Markus Elfring wrote: >>>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >>>> Date: Sun, 28 Jun 2015 16:42:04 +0200 >>>> >>>> The functions phy_exit() and phy_power_off() test whether their argument >>>> is NULL and then return immediately. >>>> Thus the test around the calls is not needed. >>>> >>>> This issue was detected by using the Coccinelle software. >>>> >>>> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> >>> >>> I haven't seen a followup to Ray's review, but in the interest of making >>> progress, I updated and applied the patch as appended. I also reviewed >>> other phy_*() calls under drivers/pci, and they all look OK (with no >>> unnecessary tests for NULL). >>> >>> This is on the pci/host-iproc branch for v4.3. >>> >> >> Hmmm....I searched my mailbox but cannot find an email with this patch >> (while I remember I reviewed and commented on the initial version of >> this patch). It must have gone into some sub-folder or deleted by me by >> accident. My bad. >> >> Nevertheless,the current patch looks good to me! > > Thanks for checking it out! Can I add your Reviewed-by to the patch below? > Sure thanks! Reviewed-by: Ray Jui <rjui@xxxxxxxxxxxx> Ray -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
