On Wed, Jul 01, 2015 at 01:06:48PM +0530, Sohny Thomas wrote: <snip> > >No, now this will introduce a new checkpatch warning that "else is not > >required after return". why did you introduce this "else"? > I did this so that the code is more readable and understandable, I > checked and checkpatch didn't call this out , so its clean. > > Otherwise the above code looks like this > > if(i) > return 1; > return 0; you should update your tree. virtpci folder has been deleted from unisys driver. As you are using an old tree, maybe that explains why checkpatch is not giving the error. regards sudip -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html