Am Mittwoch, 24. Juni 2015, 10:48:19 schrieb Dan Carpenter: Hi Dan, >The other NULL assignment isn't useful either. Also If >"entropy_collector" is NULL then we would oops calling >kzfree(entropy_collector->mem); > ^^^^^^^^^^^^^^^^^^^^^^ >Dereference. > >I don't understand the patch that you sent. We shouldn't be introducing >jent_zalloc() or jent_zfree(). Why are you adding abstractions there? The one C file should have no dependencies on any kernel header files. Thus, all links to kernel functions are wrapped. >Quite bad ones as well. What would you suggest to change? Thanks. Ciao Stephan -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html