The other NULL assignment isn't useful either. Also If "entropy_collector" is NULL then we would oops calling kzfree(entropy_collector->mem); ^^^^^^^^^^^^^^^^^^^^^^ Dereference. I don't understand the patch that you sent. We shouldn't be introducing jent_zalloc() or jent_zfree(). Why are you adding abstractions there? Quite bad ones as well. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html