At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: > > > > On 28/05/2015 15:52, Takashi Iwai wrote: > > At Thu, 28 May 2015 14:48:27 +0200, > > Quentin Lambert wrote: > >> You should use dev_groups instead of the dev_attrs field of struct > >> bus_type. This converts the MDIO bus code to use the correct field. > >> > >> These modifications were made using Coccinelle. > >> > >> Signed-off-by: Quentin Lambert <lambert.quentin@xxxxxxxxx> > > What's wrong with dev_attrs? > > (Not offending, I'm just curious where the preference for dev_groups > > is referred...) > > This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670, > its message indicates that dev_attrs is going away. OK, makes sense. Then please keep such information in the changelog. BTW, the code in question isn't MDIO at all. Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into soundbus/sysfs.c, and make it this global instead of soundbus_dev_attrs[]. Takashi -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
