At Thu, 28 May 2015 14:48:27 +0200,
Quentin Lambert wrote:
>
> You should use dev_groups instead of the dev_attrs field of struct
> bus_type. This converts the MDIO bus code to use the correct field.
>
> These modifications were made using Coccinelle.
>
> Signed-off-by: Quentin Lambert <lambert.quentin@xxxxxxxxx>
What's wrong with dev_attrs?
(Not offending, I'm just curious where the preference for dev_groups
is referred...)
thanks,
Takashi
> ---
> sound/aoa/soundbus/core.c | 3 ++-
> sound/aoa/soundbus/soundbus.h | 2 +-
> sound/aoa/soundbus/sysfs.c | 13 ++++++++-----
> 3 files changed, 11 insertions(+), 7 deletions(-)
>
> --- a/sound/aoa/soundbus/core.c
> +++ b/sound/aoa/soundbus/core.c
> @@ -150,6 +150,7 @@ static int soundbus_device_resume(struct
>
> #endif /* CONFIG_PM */
>
> +ATTRIBUTE_GROUPS(soundbus_dev);
> static struct bus_type soundbus_bus_type = {
> .name = "aoa-soundbus",
> .probe = soundbus_probe,
> @@ -160,7 +161,7 @@ static struct bus_type soundbus_bus_type
> .suspend = soundbus_device_suspend,
> .resume = soundbus_device_resume,
> #endif
> - .dev_attrs = soundbus_dev_attrs,
> + .dev_groups = soundbus_dev_groups,
> };
>
> int soundbus_add_one(struct soundbus_dev *dev)
> --- a/sound/aoa/soundbus/soundbus.h
> +++ b/sound/aoa/soundbus/soundbus.h
> @@ -199,6 +199,6 @@ struct soundbus_driver {
> extern int soundbus_register_driver(struct soundbus_driver *drv);
> extern void soundbus_unregister_driver(struct soundbus_driver *drv);
>
> -extern struct device_attribute soundbus_dev_attrs[];
> +extern struct attribute *soundbus_dev_attrs[];
>
> #endif /* __SOUNDBUS_H */
> --- a/sound/aoa/soundbus/sysfs.c
> +++ b/sound/aoa/soundbus/sysfs.c
> @@ -30,13 +30,16 @@ static ssize_t modalias_show(struct devi
>
> return length;
> }
> +static DEVICE_ATTR_RO(modalias);
>
> soundbus_config_of_attr (name, "%s\n");
> +static DEVICE_ATTR_RO(name);
> soundbus_config_of_attr (type, "%s\n");
> +static DEVICE_ATTR_RO(type);
>
> -struct device_attribute soundbus_dev_attrs[] = {
> - __ATTR_RO(name),
> - __ATTR_RO(type),
> - __ATTR_RO(modalias),
> - __ATTR_NULL
> +struct attribute *soundbus_dev_attrs[] = {
> + &dev_attr_name.attr,
> + &dev_attr_type.attr,
> + &dev_attr_modalias.attr,
> + NULL,
> };
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
