* Julia Lawall <julia.lawall@xxxxxxx> wrote: > > > 2) Exit labels bad associations because code which uses err: or out: > > > labels is often buggy as we have seen in pt_event_add(). > > > > Not if the cleanup path is robustly constructed. Multiple labels can > > also be used: > > > > - if performance is of concern > > - if we need to unroll layers of taken locks > > A cascade of labels helps the reader understand what goes with what, > in what order, because functions are not called when they are not > needed. I certainly agree for complex init/teardown sequences that are non-trivial to clean up. For the specific case of kfree() in init paths it's also a valid model to just auto-cleanup everything in the failure path, to simplify things. (which I did here.) Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
