Re: [patch] perf/x86/intel/pt: cleanup error handling in pt_pmu_hw_init()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > 2) Exit labels bad associations because code which uses err: or out:
> >    labels is often buggy as we have seen in pt_event_add().
> 
> Not if the cleanup path is robustly constructed. Multiple labels can 
> also be used:
> 
>   - if performance is of concern
>   - if we need to unroll layers of taken locks

A cascade of labels helps the reader understand what goes with what, in
what order, because functions are not called when they are not needed.

julia
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux