Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client_clunk"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> The p9_client_clunk() function tests whether its argument is NULL
>> and then returns immediately. Thus the test around the call is not needed.
>>
> 
> Not true.  You are not allowed to call p9_client_clunk(NULL).

I find that it will work in principle if we refer to the same
function implementation.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/net/9p/client.c?id=d8282ea05ad119247122de23db7d48ad6098cfa2#n1448
http://lxr.free-electrons.com/source/net/9p/client.c#L1448


> I assume this patch adds a bug.

It can happen that you will not like a corresponding error message
if the callers will still pass null pointers eventually.

... Trying to clunk with NULL ...


> I assume this patch adds a bug.  You have tried to introduce several of these
> kinds of bugs.

Do any other contributors want to reject my update suggestions
around software components for "fs/9p"?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux