On Fri, Dec 26, 2014 at 6:35 AM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote: > Convert a call to init_timer and accompanying intializations of > the timer's data and function fields to a call to setup_timer. > > A simplified version of the semantic match that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression t,f,d; > @@ > > -init_timer(&t); > +setup_timer(&t,f,d); > -t.function = f; > -t.data = d; > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > Thanks, applied. -Bryan > --- > drivers/leds/led-class.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > index dbeebac..291ca45 100644 > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -239,9 +239,8 @@ int led_classdev_register(struct device *parent, struct led_classdev *led_cdev) > > INIT_WORK(&led_cdev->set_brightness_work, set_brightness_delayed); > > - init_timer(&led_cdev->blink_timer); > - led_cdev->blink_timer.function = led_timer_function; > - led_cdev->blink_timer.data = (unsigned long)led_cdev; > + setup_timer(&led_cdev->blink_timer, led_timer_function, > + (unsigned long)led_cdev); > > #ifdef CONFIG_LEDS_TRIGGERS > led_trigger_set_default(led_cdev); > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html