Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
From: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 05 Dec 2014 13:50:24 +0100
Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linux-ppp@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Eric Dumazet <eric.dumazet@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx>
In-reply-to: <20141205122315.GC4912@mwanda>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

>> The data structure element "sha1" was assigned a null pointer by the
>> mppe_alloc() after a function call "crypto_alloc_hash" failed.
> 
> This patch is also buggy.

Do you really want to keep a variable reset after a detected failure?

Regards,
Markus

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- Re: [PATCH with Coccinelle?] Deletion of unnecessary checks before specific function calls
  - From: SF Markus Elfring
- [PATCH 0/3] net-PPP: Deletion of a few unnecessary checks
  - From: SF Markus Elfring
- [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: SF Markus Elfring
- Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: Sergei Shtylyov
- Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: SF Markus Elfring
- Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: Sergei Shtylyov
- [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks
  - From: SF Markus Elfring
- [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
  - From: SF Markus Elfring
- Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
  - From: Dan Carpenter

Prev by Date: Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()
Next by Date: Re: [patch] drm/tegra: checking IS_ERR() instead of NULL
Previous by thread: Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
Next by thread: Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]