Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 5 Dec 2014 15:23:15 +0300
Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>, Paul Mackerras <paulus@xxxxxxxxx>, linux-ppp@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, Eric Dumazet <eric.dumazet@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx>
In-reply-to: <5480DE25.2020802@users.sourceforge.net>
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Dec 04, 2014 at 11:20:21PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 4 Dec 2014 22:42:30 +0100
> 
> The data structure element "sha1" was assigned a null pointer by the
> mppe_alloc() after a function call "crypto_alloc_hash" failed.

This patch is also buggy.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Follow-Ups:
- Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
  - From: Dan Carpenter
- Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
  - From: SF Markus Elfring

References:
- Re: [PATCH with Coccinelle?] Deletion of unnecessary checks before specific function calls
  - From: SF Markus Elfring
- [PATCH 0/3] net-PPP: Deletion of a few unnecessary checks
  - From: SF Markus Elfring
- [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: SF Markus Elfring
- Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: Sergei Shtylyov
- Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: SF Markus Elfring
- Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call "kfree"
  - From: Sergei Shtylyov
- [PATCH v2 0/6] net-PPP: Deletion of a few unnecessary checks
  - From: SF Markus Elfring
- [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
  - From: SF Markus Elfring

Prev by Date: Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()
Next by Date: Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()
Previous by thread: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
Next by thread: Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]