On Wed, Dec 03, 2014 at 12:17:10AM +0300, Dan Carpenter wrote: > The missing error handling here is not especially harmful but static > checkers complain that "i" can be used uninitialized. > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Applied, thank you. > > diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c > index cb32e2b..21bea52 100644 > --- a/drivers/input/keyboard/lm8323.c > +++ b/drivers/input/keyboard/lm8323.c > @@ -616,6 +616,8 @@ static ssize_t lm8323_set_disable(struct device *dev, > unsigned int i; > > ret = kstrtouint(buf, 10, &i); > + if (ret) > + return ret; > > mutex_lock(&lm->lock); > lm->kp_enabled = !i; -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html