On 12/03/2014 01:14 AM, Greg Kroah-Hartman wrote:
On Sun, Nov 30, 2014 at 05:59:34PM +0100, Julia Lawall wrote:
From: Julia Lawall <julia@xxxxxxx>
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
type T;
@@
{
... when any
T x[...];
... when any
when exists
- memset
+ memzero_explicit
(x,
-0,
...)
... when != x
when strict
}
// </smpl>
This change was suggested by Daniel Borkmann <dborkman@xxxxxxxxxx>
Signed-off-by: Julia Lawall <julia@xxxxxxx>
---
Daniel Borkmann suggested that these patches could go through Herbert Xu's
cryptodev tree.
Why? There's no dependancy on anything in the cryptodev tree,
memzero_explicit is in Linus's tree now.
Sorry, I guess this was not really clear, that comment actually only
refers to the arch/*/crypto/ patches.
Anyway, thanks for queueing this up, Greg.
Cheers,
Daniel
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
