On Wed, Nov 19, 2014 at 12:26:45PM +0100, SF Markus Elfring wrote: > --- a/drivers/base/power/wakeup.c > +++ b/drivers/base/power/wakeup.c > @@ -267,8 +267,7 @@ int device_wakeup_disable(struct device *dev) > return -EINVAL; > > ws = device_wakeup_detach(dev); > - if (ws) > - wakeup_source_unregister(ws); > + wakeup_source_unregister(ws); In the original code, it's clear that the programmer thought about what happens when the device_wakeup_detach() returns NULL but in the new code that's not clear. I guess the information is still there in the git archive, but why hide the good code by covering it with confusing code? regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
