At Mon, 17 Nov 2014 13:41:19 +0100, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Mon, 17 Nov 2014 13:35:54 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Applied, thanks. Takashi > --- > sound/ppc/pmac.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/ppc/pmac.c b/sound/ppc/pmac.c > index 8a431bc..5a13b22 100644 > --- a/sound/ppc/pmac.c > +++ b/sound/ppc/pmac.c > @@ -887,8 +887,7 @@ static int snd_pmac_free(struct snd_pmac *chip) > } > } > > - if (chip->pdev) > - pci_dev_put(chip->pdev); > + pci_dev_put(chip->pdev); > of_node_put(chip->node); > kfree(chip); > return 0; > -- > 2.1.3 > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
