At Mon, 17 Nov 2014 13:12:15 +0100, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Mon, 17 Nov 2014 13:04:14 +0100 > > The release_firmware() function tests whether its argument is NULL and then > return immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Applied, thanks. Takashi > --- > sound/pci/rme9652/hdsp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c > index 7646ba1..0ae568d 100644 > --- a/sound/pci/rme9652/hdsp.c > +++ b/sound/pci/rme9652/hdsp.c > @@ -5368,8 +5368,7 @@ static int snd_hdsp_free(struct hdsp *hdsp) > > snd_hdsp_free_buffers(hdsp); > > - if (hdsp->firmware) > - release_firmware(hdsp->firmware); > + release_firmware(hdsp->firmware); > vfree(hdsp->fw_uploaded); > > if (hdsp->iobase) > -- > 2.1.3 > > -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
