Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Julia Lawall <julia.lawall@xxxxxxx>
Subject: Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"
From: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 16 Nov 2014 17:57:24 +0100
Cc: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>, Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Coccinelle <cocci@xxxxxxxxxxxxxxx>
In-reply-to: <alpine.DEB.2.10.1411161639310.2364@hadrien>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

> The if around the module_put is helpful to the reader to understand
> that this possibility exists.

I have got a different opinion. I would still prefer a small code clean-up there.

Regards,
Markus

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

References:
- Re: [PATCH with Coccinelle?] Deletion of unnecessary checks before specific function calls
  - From: SF Markus Elfring
- [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"
  - From: SF Markus Elfring
- Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"
  - From: Julia Lawall
- Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"
  - From: SF Markus Elfring
- Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"
  - From: Julia Lawall

Prev by Date: Re: [PATCH 1/1] kernel-trace: Deletion of an unnecessary check before the function call "iput"
Next by Date: [PATCH v2 0/2] kernel-trace: Fixes around the jump label "fail_address_parse"
Previous by thread: Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"
Next by thread: Re: [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put"
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]