From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Sun, 16 Nov 2014 12:20:31 +0100 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- kernel/kprobes.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 3995f54..f1e7d45 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -1527,8 +1527,7 @@ int register_kprobe(struct kprobe *p) out: mutex_unlock(&kprobe_mutex); - if (probed_mod) - module_put(probed_mod); + module_put(probed_mod); return ret; } -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
