On Wed, Nov 12, 2014 at 10:28:41PM +0100, SF Markus Elfring wrote: > > This is especially true if you have trained yourself to know that > > free_netdev() can't accept NULL pointers. > > Do you need to adjust your concerns a bit over time when function variants > provide a corresponding safety check in their implementations? No. Really, free_netdev vs rtw_free_netdev is just an example where it is really bad, but I feel that all of these patches are misguided and harmful. We should have an if statement if the allocation is optional, we should not have an if statement if the allocation is required. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
