Hello Lendacky, Thomas,
The patch c5aa9e3b8156: "amd-xgbe: Initial AMD 10GbE platform driver"
from Jun 5, 2014, leads to the following Smatch warning:
drivers/net/ethernet/amd/xgbe/xgbe-dev.c:1633 xgbe_dev_read()
warn: we tested 'err' before and it was 'true'
drivers/net/ethernet/amd/xgbe/xgbe-dev.c
1628 /* Check for errors (only valid in last descriptor) */
1629 err = XGMAC_GET_BITS_LE(rdesc->desc3, RX_NORMAL_DESC3, ES);
1630 etlt = XGMAC_GET_BITS_LE(rdesc->desc3, RX_NORMAL_DESC3, ETLT);
1631 DBGPR(" err=%u, etlt=%#x\n", err, etlt);
1632
1633 if (!err || (err && !etlt)) {
^^^^^^^^^^^^^^^^^^^^^^
Smatch is saying that we could re-write this as:
if (!err || !etlt) {
Which is true, but I'm not sure if that was really the original intent
of the code. If it was then maybe we could make it more explicit by
saying:
if (etlt = 0x00) {
/* do nothing */
} else if (!err) {
if (etlt == 0x09 &&
...
} else {
if (etlt == 0x05 || etlt == 0x06)
...
1634 if ((etlt == 0x09) &&
1635 (netdev->features & NETIF_F_HW_VLAN_CTAG_RX)) {
1636 XGMAC_SET_BITS(packet->attributes, RX_PACKET_ATTRIBUTES,
1637 VLAN_CTAG, 1);
1638 packet->vlan_ctag = XGMAC_GET_BITS_LE(rdesc->desc0,
1639 RX_NORMAL_DESC0,
1640 OVT);
1641 DBGPR(" vlan-ctag=0x%04x\n", packet->vlan_ctag);
1642 }
1643 } else {
1644 if ((etlt == 0x05) || (etlt == 0x06))
1645 XGMAC_SET_BITS(packet->attributes, RX_PACKET_ATTRIBUTES,
1646 CSUM_DONE, 0);
1647 else
1648 XGMAC_SET_BITS(packet->errors, RX_PACKET_ERRORS,
1649 FRAME, 1);
1650 }
1651
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
