On Mon, Nov 10, 2014 at 10:00:20PM +0100, Jozsef Kadlecsik wrote:
> On Mon, 10 Nov 2014, Pablo Neira Ayuso wrote:
>
> > On Mon, Nov 10, 2014 at 03:27:51PM +0100, Jozsef Kadlecsik wrote:
> > > On Mon, 10 Nov 2014, Pablo Neira Ayuso wrote:
> > > > >From other similar code in that location, I can see Jozsef is using
> > > > this pattern:
> > > >
> > > > if (*len != sizeof(struct ip_set_req_version)) {
> > > > ret = -EINVAL;
> > > > goto done;
> > > > }
> > > >
> > > > I think it would be good to stick to that for consistency. Thanks.
> > >
> > > Absolutely, yes.
> > >
> > > Acked-by: Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>
> >
> > OK, then does this look fine to you? I took over Dan's patch and gave
> > it another spin. See it attached, thanks.
>
> Yes, it's better this way, thanks!
Applied, thanks Dan and Jozsef.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
