re: cxgb4: Cleanup macros so they follow the same style and look consistent, part 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Hariprasad Shenai,

The patch e2ac9628959c: "cxgb4: Cleanup macros so they follow the
same style and look consistent, part 2" from Nov 7, 2014, leads to
the following static checker warning:

	drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:5756 adap_init0()
	info: ignoring unreachable code.

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
  5739                          if (ret < 0)
  5740                                  ret = adap_init0_no_config(adap, reset);
  5741                          else {
  5742                                  /*
  5743                                   * The firmware provides us with a memory
  5744                                   * buffer where we can load a Configuration
  5745                                   * File from the host if we want to override
  5746                                   * the Configuration File in flash.
  5747                                   */
  5748  
  5749                                  ret = adap_init0_config(adap, reset);
  5750                                  if (ret == -ENOENT) {
  5751                                          dev_info(adap->pdev_dev,
  5752                                              "No Configuration File present "
  5753                                              "on adapter. Using hard-wired "
  5754                                              "configuration parameters.\n");
  5755                                          goto bye;
                                                ^^^^^^^^

This looks like it was added to the commit accidentally.  It creates
a new static checker warning.

  5756                                          ret = adap_init0_no_config(adap, reset);
  5757                                  }
  5758                          }

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux