On Thu, May 22, 2014 at 04:44:46PM +0200, Emil Goode wrote: > Hello Dan, > > On Thu, May 22, 2014 at 04:50:16PM +0300, Dan Carpenter wrote: > > On Thu, May 22, 2014 at 03:14:42PM +0200, Emil Goode wrote: > > > We forgot to free pdev->dev.dma_mask as it is not freed > > > by platform_device_put(). > > > > > > > Every function which calls imx31_alloc_mx3_camera() is buggy. That > > means that, at best, it is a 2 on Rusty's API rating. > > http://sweng.the-davies.net/Home/rustys-api-design-manifesto > > > > The correct fix is to introduce an imx31_free_mx3_camera() otherwise we > > will just keep introducing these bugs. > > I guess I could add this to arch/arm/mach-imx/devices/platform-ipu-core.c > it would be a very small function though. A small function is fine. :) regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
