On Thu, May 22, 2014 at 03:14:42PM +0200, Emil Goode wrote: > We forgot to free pdev->dev.dma_mask as it is not freed > by platform_device_put(). > Every function which calls imx31_alloc_mx3_camera() is buggy. That means that, at best, it is a 2 on Rusty's API rating. http://sweng.the-davies.net/Home/rustys-api-design-manifesto The correct fix is to introduce an imx31_free_mx3_camera() otherwise we will just keep introducing these bugs. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html