On Thu, Feb 20, 2014 at 2:55 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > Guys, what Manu is saying is purest nonsense. The "lock" variable is a > stack variable, it's not a "demodulator Read-modify-Write register". > The implications of changing "if (!lock)" to "if (lock)" are simple and > obvious. Sorry, you mistook. By demodulator Read-modify-Write register, I do really mean a register on the demodulator. If you do miss a read when flipping a logic, it does indeed make a large difference. > > He's not reviewing patches, he's just NAKing them. It's not helpful. > Uh !? I said "Ok, will have a look at it later, the second lock test might be superfluous, which will fix your static checker as well." Where's the NAK in there ? Just said that, I prefer a simplified version, rather than that logic flip. Regards, Manu -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
