Hi Dan, On Thu, Feb 6, 2014 at 2:58 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > 1) We can flip the "if (!lock)" check to "if (lock) return lock;" and > then remove a big chunk of indenting. > 2) There is a redundant "if (!lock)" which we can remove since we > already know that lock is zero. This removes another indent level. The stv090x driver is a mature, but slightly complex driver supporting quite some different configurations. Is it that some bug you are trying to fix in there ? I wouldn't prefer unnecessary code churn in such a driver for something as simple as gain in an indentation level. Thanks, Manu -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
