On Thu, Nov 07, 2013 at 09:48:08AM +0100, Takashi Iwai wrote: > At Thu, 7 Nov 2013 11:09:54 +0300, > Dan Carpenter wrote: > > > > There is a 2 byte hole after "info.func_nr" so we could leak unitialized > > stack information to userspace. > > > > Fixes: 1da177e4c3f4 ('Linux-2.6.12-rc2') > > Does this help at all? It means that the bug has been there even > before moving to git. I think it's better to be removed for avoid > confusion. I think if you are back porting it then you know it goes back all the way. That seems useful. The Fixes tag is still new so it's not totally clear what the rules are. I don't have strong feelings about this either way. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html