On Fri, Jul 26, 2013 at 05:51:27PM +0200, Julia Lawall wrote:
> On Fri, 26 Jul 2013, Kumar Gaurav wrote:
>
> >Hi Dan,
> >
> >I had sent my first patch with lots of changes which wasn't correct.
> >Now i'm splitting them in parts as below:
> >1.One patch for variable name replacement (one patch per file)
> >2.One Patch for fixing coding style issue (one patch per file)
> >3.One Patch for fixing warning about using pr_warn,pr_error
> >functions instead of printk(KERN_WARNING... and printk(KERN_ERR...
> >(havn't replaced yet as last time you weren't convinced)
The pr_warn() thing works differently from how you were doing it.
wrong : pr_warn(KERN_WARN "msg\n");
correct: pr_warn("msg\n");
But I think Julia has a good suggestion.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
