On Sat, 2013-04-20 at 23:39 +0300, Dan Carpenter wrote: > On Fri, Apr 19, 2013 at 05:33:29PM -0400, David Miller wrote: > > From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Date: Wed, 17 Apr 2013 10:10:38 +0300 > > > > > The "reason" can come from skb->data[] and it hasn't been capped so it > > > can be from 0-255 instead of just 0-6. For example in irlmp_state_dtr() > > > the code does: > > > > > > reason = skb->data[3]; > > > ... > > > irlmp_disconnect_indication(self, reason, skb); > > > > > > Also LMREASON has a couple other values which don't have entries in the > > > irlmp_reasons[] array. And 0xff is a valid reason as well which means > > > "unknown". > > > > > > So far as I can see we don't actually care about "reason" except for in > > > the debug code. > > > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > > Applied but please put the subsystem prefix outside of [] which get > > stripped by git am and other tools. I fixed it up to be "irda: ". > > > > Sorry about that. I won't do it again. > > It's weird because the prefix was cut and pasted from an earlier > commit. Also [media] and [SCSI] use square brackets in their > subsystems. I tried some experiments with "git am" and you're right > that "git am" always strips out the square bracket stuff. Odd. The -k option suppresses this behaviour, but then it will also keep [PATCH]. It's a shame there's no option to strip just \[PATCH[^]]*\] Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
