Acked-by: Robin Holt <holt@xxxxxxx> On Sun, Apr 21, 2013 at 12:33:34PM -0500, Dimitri Sivanich wrote: > Acked-by: Dimitri Sivanich <sivanich@xxxxxxx> > > On Sun, Apr 21, 2013 at 08:01:07PM +0300, Dan Carpenter wrote: > > The "info.fill" array isn't initialized so it can leak uninitialized > > stack information to user space. > > > > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > --- > > v2: style changes > > > > diff --git a/drivers/misc/sgi-gru/grufile.c b/drivers/misc/sgi-gru/grufile.c > > index 44d273c..0535d1e 100644 > > --- a/drivers/misc/sgi-gru/grufile.c > > +++ b/drivers/misc/sgi-gru/grufile.c > > @@ -172,6 +172,7 @@ static long gru_get_config_info(unsigned long arg) > > nodesperblade = 2; > > else > > nodesperblade = 1; > > + memset(&info, 0, sizeof(info)); > > info.cpus = num_online_cpus(); > > info.nodes = num_online_nodes(); > > info.blades = info.nodes / nodesperblade; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
