This is a user pointer. Changing the memcpy() to copy_to_user()
fixes a hang on my system.
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
---
I'm not very familiar with this code, so please review this
carefully.
diff --git a/net/rxrpc/ar-recvmsg.c b/net/rxrpc/ar-recvmsg.c
index 4b48687..428501f 100644
--- a/net/rxrpc/ar-recvmsg.c
+++ b/net/rxrpc/ar-recvmsg.c
@@ -143,10 +143,15 @@ int rxrpc_recvmsg(struct kiocb *iocb, struct socket *sock,
/* copy the peer address and timestamp */
if (!continue_call) {
- if (msg->msg_name && msg->msg_namelen > 0)
- memcpy(msg->msg_name,
- &call->conn->trans->peer->srx,
- sizeof(call->conn->trans->peer->srx));
+ if (msg->msg_name && msg->msg_namelen > 0) {
+ ret = copy_to_user((void __user *)msg->msg_name,
+ &call->conn->trans->peer->srx,
+ sizeof(call->conn->trans->peer->srx));
+ if (ret) {
+ ret = -EFAULT;
+ goto copy_error;
+ }
+ }
sock_recv_ts_and_drops(msg, &rx->sk, skb);
}
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
