On Fri, Mar 15, 2013 at 01:43:39PM +0000, Marciniszyn, Mike wrote: > Oddly, I don't see an issue with qib, which masks the opcode. > > Would: > opcode = (be32_to_cpu(ohdr->bth[0]) >> 24) & 0x7f; > > also correct the issue without adding the if test. At this point > the hardware has already validated the opcode, so there is no > value in the fail handling. > > What args are you using with smatch? > Gar sorry, for the noise. You can just drop this then. This is some custom stuff that probably has too many false positives to push. Doing an "& 0x7f" would silence the warning but if this is validated by the hardware then we don't need it. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
