On Wed, 26 Sep 2012 21:57:39 +0400
Vyacheslav Dubeyko <slava@xxxxxxxxxxx> wrote:
> On Sep 26, 2012, at 8:07 PM, Fengguang Wu wrote:
>
> > Hi Vyacheslav,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> > head: dad0019944369f58c193c1991c39ffda7ff584d2
> > commit: 910b5a60f4229643fb0e21d26d6ba61de24e5df8 [342/412] hfsplus: rework functionality of getting, setting and deleting of extended attributes
> > config: x86_64-randconfig-s007 (attached as .config)
> >
> > All error/warnings:
> >
> > fs/hfsplus/ioctl.c: In function 'hfsplus_setxattr':
> > fs/hfsplus/ioctl.c:249:2: error: implicit declaration of function 'hfsplus_attr_exists' [-Werror=implicit-function-declaration]
> > fs/hfsplus/ioctl.c:255:3: error: implicit declaration of function 'hfsplus_delete_attr' [-Werror=implicit-function-declaration]
> > fs/hfsplus/ioctl.c:258:3: error: implicit declaration of function 'hfsplus_create_attr' [-Werror=implicit-function-declaration]
> > fs/hfsplus/ioctl.c: In function 'hfsplus_getxattr':
> > fs/hfsplus/ioctl.c:378:2: error: implicit declaration of function 'hfsplus_alloc_attr_entry' [-Werror=implicit-function-declaration]
> > fs/hfsplus/ioctl.c:378:8: warning: assignment makes pointer from integer without a cast [enabled by default]
> > fs/hfsplus/ioctl.c:390:2: error: implicit declaration of function 'hfsplus_find_attr' [-Werror=implicit-function-declaration]
> > fs/hfsplus/ioctl.c:439:2: error: implicit declaration of function 'hfsplus_destroy_attr_entry' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> >
> > vim +249 fs/hfsplus/ioctl.c
> > 243
> > 244 if (!HFSPLUS_SB(inode->i_sb)->attr_tree) {
> > 245 err = -EOPNOTSUPP;
> > 246 goto end_setxattr;
> > 247 }
> > 248
> >> 249 if (hfsplus_attr_exists(inode, name)) {
> > 250 if (flags & XATTR_CREATE) {
> > 251 printk(KERN_ERR "hfs: xattr exists yet\n");
> > 252 err = -EOPNOTSUPP;
> >
>
> Hi Fengguang,
>
> Sorry, I can't reproduce your issue.
>
> I clone linux-next repository then "git checkout remotes/origin/akpm". I can compile kernel successfully with your .config files without any errors or warnings. I use gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.
>
(top-posting repaired - please don't do that!)
This is because you're testing the whole tree, whereas Fengguang test
the tree after each individual patch.
This build error is introduced in
hfsplus-rework-functionality-of-getting-setting-and-deleting-of-extended-attributes
and then gets fixed up in the next patch,
hfsplus-add-support-of-manipulation-by-attributes-file. This is
undesirable because it introduces a bisection hole - if someone is
doing a `git bisect' search and they land on this commit, their kernel
won't compile.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
