On Tue, Sep 25, 2012 at 04:13:42PM +0800, Fengguang Wu wrote: > Hi Frederic, > > FYI, there are new smatch warnings show up in > > 37bee0638b95bc25ed67ec240eb56e25aef2f3ee x86: Unspaghettize do_general_protection() > > All smatch warnings: > > + arch/x86/kernel/traps.c:276 do_general_protection() warn: add some parenthesis here? > arch/x86/kernel/traps.c:604 math_state_restore() info: ignoring unreachable code. > > vim +276 arch/x86/kernel/traps.c > > 272 > 273 tsk->thread.error_code = error_code; > 274 tsk->thread.trap_nr = X86_TRAP_GP; > 275 if (!notify_die(DIE_GPF, "general protection fault", regs, error_code, > > 276 X86_TRAP_GP, SIGSEGV) == NOTIFY_STOP) Precedence error. Should != NOTIFY_STOP. Same for the other email. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
