On Sat, 22 Sep 2012 08:50:21 +0800, Fengguang Wu wrote: > FYI, kernel build failed on > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > tty-next > head: ac57e7f38ea6fe7358cd0b7a2f2d21aef5ab70cd > commit: 84c3b84860440a9e3a3666c14112f41311b8f623 [10/16] > compat_ioctl: Add RS-485 IOCTLs to the list > config: mips-fuloong2e_defconfig > > All related error/warning messages: > > fs/compat_ioctl.c:869:1: error: 'TIOCSRS485' undeclared here (not in > a function) > fs/compat_ioctl.c:870:1: error: 'TIOCGRS485' undeclared here (not in > a function) I could fix this by defining these IOCTLs for all architectures that don't have them yet, but I'm unsure of what values to give them or why MIPS isn't using 'include/asm-generic/ioctls.h'. Perhaps it is better to leave adding those IOCTLs up to those who add the first RS-485 capable driver for that platform and to wrap the use of these defines in compat_ioctl.c with #ifdefs, as I've done in this patch. What do you think is best? Cheers, Jaeden Amero Jaeden Amero (1): compat_ioctl: Avoid using undefined RS-485 IOCTLs fs/compat_ioctl.c | 4 ++++ 1 file changed, 4 insertions(+) -- 1.7.12 -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
