RE: [patch] mwifiex: potential corruption in mwifiex_update_uap_custom_ie()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dan,

Thanks for the patch.

> ap_custom_ie is a struct mwifiex_ie_list which is quite different and
> also larger than struct mwifiex_ie.  It's a difference between 4196
> bytes and 262.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Tested-by: Stone Piao <piaoyun@xxxxxxxxxxx>
Acked-by: Bing Zhao <bzhao@xxxxxxxxxxx>

Thanks,
Bing

> ---
> This is a static checker fix and I don't have the hardware to test it.
> Please review it carefully.
> 
> diff --git a/drivers/net/wireless/mwifiex/ie.c b/drivers/net/wireless/mwifiex/ie.c
> index 1d8dd00..fa3a80f 100644
> --- a/drivers/net/wireless/mwifiex/ie.c
> +++ b/drivers/net/wireless/mwifiex/ie.c
> @@ -160,7 +160,7 @@ mwifiex_update_uap_custom_ie(struct mwifiex_private *priv,
>  	u16 len;
>  	int ret;
> 
> -	ap_custom_ie = kzalloc(sizeof(struct mwifiex_ie), GFP_KERNEL);
> +	ap_custom_ie = kzalloc(sizeof(*ap_custom_ie), GFP_KERNEL);
>  	if (!ap_custom_ie)
>  		return -ENOMEM;
> 
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux