On Sun, Sep 23, 2012 at 09:13:05PM +0530, Harsh Kumar wrote: > Hi, > > I have created a patch for the first time. It is a small change (only > 3 line change). I ran checkpatch.pl on my patch file and there were no > problems. But can somebody please tell me: > > 1.) Are the fixes for checkpatch.pl issues correct? > 2.) Is the patch file correctly made? I'm not sure what the problem was you were fixing. Only the third line is correct. The patch should be included in the email. It needs a proper subject, a patch description and a Signed-off-by line. Email the patch to yourself. Save the raw email including headers and everything. `cat raw_email.txt | git am`. `git log -p`. Look through the patch and verify that the patch description and everything looks good. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
