Re: [can:master 118/170] ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined!

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 21, 2012 at 12:24:18PM -0400, David Miller wrote:
> From: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Date: Fri, 21 Sep 2012 19:27:40 +0800
> 
> > Hi Ben,
> > 
> > FYI, kernel build failed on
> > 
> > tree:   git://gitorious.org/linux-can/linux-can-next master
> > head:   029d8ada9150a1177f09148284b5cd27a30d4db7
> > commit: 025e36332573177ecd7c12730e18a4390f994f05 [118/170] llc2: Remove dead code for state machine
> > config: x86_64-allmodconfig
> > 
> > All related error/warning messages:
> > 
> > ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined!
> 
> The very next commit, written by me, after Ben's fixes this build
> error.

OK..

> It wasn't added by the CAN tree so bugging them is very inappropriate,
> the change came from the net-next tree.

Yup, I got an idea to fix it! :)

The root cause is the CAN tree get tested before the net-next tree
that it bases on, and I'm CCing the CAN list because it "seems" to be
testing the CAN tree.

The fix is to

a) Test the trees as soon as they are published, which will naturally
   result in upstream trees being tested first. Currently some of the
   build threads are overloaded, which leads to out-of-order testing
   and some missed tests.

b) Use the pair (committer, git tree) to find the related mailing list.
   The git tree alone is not reliable information, because one tree
   can pull from the others, in which case the committer is actually
   more reliable than the git url.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux