On Fri, Sep 21, 2012 at 11:51:22AM +0300, Dan Carpenter wrote: > On Fri, Sep 21, 2012 at 11:44:58AM +0300, Dan Carpenter wrote: > > On Fri, Sep 21, 2012 at 04:40:05PM +0800, Fengguang Wu wrote: > > > On Fri, Sep 21, 2012 at 01:31:25AM -0700, Eric W. Biederman wrote: > > > > Fengguang Wu <fengguang.wu@xxxxxxxxx> writes: > > > > > > > > > Hi Eric, > > > > > > > > > > FYI, there are new smatch warnings show up in > > > > > > > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git userns-always-map-user-v58 > > > > > head: cf7198a6b74906aa363a8507d6f9cbdf56e42dc1 > > > > > commit: 84ec77ea8a96e568f20bec4465c1fbde2c066cf8 [86/150] userns: Convert ncpfs to use kuid and kgid where appropriate > > > > > > > > > > All smatch warnings: > > > > > > > > > > + fs/ncpfs/inode.c:335 ncp_show_options() warn: if(); > > > > > fs/ncpfs/inode.c:654 ncp_fill_super() Error invalid range 4096 to -1 > > > > > > > > Good catch. Thanks. > > > > > > > > Did you just start running smatch tests? I haven't looked at ncpfs for > > > > a long time. > > > > > > Yes. :) I don't quite get the old "invalid range 4096 to -1" warning, > > > perhaps it's fine to just ignore it. > > > > > > > Yes, yes. This shouldn't be there in the latest Smatch. (I thought > > you were on that thread). Let me know if it's still an issue. > > So I haven't totally puplicized this but Smatch has a --spammy > option. If you want something disabled, I could easily move it > under the --spammy option so it doesn't show up by default. > > Just add and if (!option_spammy) return in front of the print > statement. I'm happy to merge all those patches. OK, thanks! Fengguang -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
