Fengguang Wu wrote at Wednesday, September 19, 2012 5:34 PM: > Hi Stephen, > > FYI, there are new sparse warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6.git for-next > head: 144c94c99ad2f20ff37ca77147a10da7718895ad > commit: 9582fdcb6fcf1b596a83b161a2ea886272d2a62f [47/76] mfd: max8907: Add power off control > > All sparse warnings: > > + drivers/mfd/max8907.c:179:16: sparse: symbol 'max8907_pm_off' was not declared. Should it be static? ... > Please consider folding the attached diff :-) Yes, the diff is correct; please consider it: Acked-by: Stephen Warren <swarren@xxxxxxxxxx> -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html