On 09/19/2012 07:19 PM, Fengguang Wu wrote: > On Wed, Sep 19, 2012 at 07:06:39PM +0200, Lars-Peter Clausen wrote: >> On 09/19/2012 06:31 PM, Fengguang Wu wrote: >>> Hi Lars-Peter, >>> >>> FYI, there are new coccinelle warnings show up in >>> >>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next >>> head: 5d06e3df280bd230e2eadc16372e62818c63e894 >>> commit: a0e545e0e75006a7de0e9bc5397f6b44c61990b2 [86/151] staging:iio:hwmon bridge: Use iio_read_channel_processed >> >> Hi, >> >> Thanks for info, patch looks good, but the warning is not introduced by the >> commit you mention, though. > > Sorry! I should probably change the prompt message accordingly, > especially removing the word "new". Because I'm reporting new as > well as old coccinelle warnings: > > In fact I've never run a complete coccinelle check, mark all existing > warnings as "old" and ignore them. It feels not good to ignore all > existing problems in that way. On the other hand, it's also not > feasible to check/fix all of them in one day. > > So I decided to report old/new coccinelle warnings for the files > touched by new commits. Which looks like the most manageable way. > However it means the below message is not always accurate and > sometimes I forgot to change it accordingly: > Ok. I think for IIO I'll just go through all the existing warnings and fix them, that should avoid old warnings with new patches. - Lars -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
