[scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Saurav,

FYI, there are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
head:   71cfff4af0525891941199b142b759d00b293959
commit: 387fddaa3564503c9f82d091d2ebe390f3af62a1 [92/128] [SCSI] qla2xxx: Implementation of bidirectional.
config: x86_64-allmodconfig

All error/warnings:

drivers/scsi/qla2xxx/qla_isr.c: In function 'qla2x00_status_entry':
drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/scsi/qla2xxx/qla_isr.c:1558:11: note: 'rval' was declared here

It could be uninitialized due to the test in line 1598.

vim +1684 drivers/scsi/qla2xxx/qla_isr.c
  1596         switch (comp_status) {
  1597         case CS_COMPLETE:
> 1598                 if (scsi_status == 0) {
  1599                         bsg_job->reply->reply_payload_rcv_len =
  1600
  bsg_job->reply_payload.payload_len;
  1601                         rval = EXT_STATUS_OK;
  1602                 }
  1603                 goto done;
  1604 
...
  1674			ql_dbg(ql_dbg_user, vha, 0x70bb,
  1675			    "Command completed with completion status=0x%x "
  1676			    "thread_id=%d\n", comp_status, thread_id);
  1677			rval = EXT_STATUS_ERR;
  1678			break;
  1679		}
  1680			bsg_job->reply->reply_payload_rcv_len = 0;
  1681	
  1682	done:
  1683		/* Return the vendor specific reply to API */
> 1684		bsg_job->reply->reply_data.vendor_reply.vendor_rsp[0] = rval;
  1685		bsg_job->reply_len = sizeof(struct fc_bsg_reply);
  1686		/* Always return DID_OK, bsg will send the vendor specific response
  1687		 * in this case only */
  1688		sp->done(vha, sp, (DID_OK << 6));
  1689	
  1690	}

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux