We're placing the NUL terminator one character beyond the end of the buffer here. Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> --- This change obviously don't make the code worse, but I'm not positive it's the right fix. I'm not sure the lines before are doing the right thing either, if we had two chars of remaining space then wouldn't it be better to put the new line and NUL in the unused space? If you decide to do it differently, then please feel to sent a patch for that and give me a Reported-by cookie. diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c index eec85b5..ff271ff0 100644 --- a/drivers/hid/hid-picolcd_debugfs.c +++ b/drivers/hid/hid-picolcd_debugfs.c @@ -390,7 +390,7 @@ static void dump_buff_as_hex(char *dst, size_t dst_sz, const u8 *data, dst[j--] = '\0'; dst[j] = '\n'; } else - dst[j] = '\0'; + dst[dst_sz - 1] = '\0'; } void picolcd_debug_out_report(struct picolcd_data *data, -- To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
